Extra checks in UI when deleting accounts by Imvedansh · Pull Request #10760 · apache/cloudstack

Imvedansh · 2025-04-21T15:39:43Z

Description

This PR fixes #9480

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>

Imvedansh · 2025-04-23T10:22:14Z

@blueorangutan ui

blueorangutan · 2025-04-23T10:23:03Z

@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-04-23T10:40:27Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10760 (QA-JID-604)

codecov · 2025-04-23T15:14:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.16%. Comparing base (9d9737a) to head (1d3e374).
Report is 7 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10760   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11332    11337    +5     
=========================================
  Files          5412     5414    +2     
  Lines        475043   475078   +35     
  Branches      57963    57966    +3     
=========================================
+ Hits          72049    72069   +20     
- Misses       394939   394951   +12     
- Partials       8055     8058    +3

Flag	Coverage Δ
uitests	`4.29% <ø> (-0.01%)`	⬇️
unittests	`15.89% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Imvedansh · 2025-04-23T17:43:06Z

@blueorangutan ui

blueorangutan · 2025-04-23T17:44:04Z

@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-04-23T18:00:23Z

UI build failed: ✖️
(SL-JID-605)

Imvedansh · 2025-04-23T19:03:03Z

@blueorangutan ui

blueorangutan · 2025-04-23T19:04:04Z

@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-04-23T19:21:41Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10760 (QA-JID-606)

Imvedansh · 2025-04-23T19:24:33Z

@bernardodemarco WDYT?

DaanHoogland

looks good, tested in qa

DaanHoogland · 2025-04-24T07:16:06Z

@Imvedansh , were you going to implement the multiple delete as well?

Imvedansh · 2025-04-24T12:06:54Z

@Imvedansh , were you going to implement the multiple delete as well?

yes, without it this would be fragmental!
Working on it @DaanHoogland

bernardodemarco

@Imvedansh looking nice. Here are some suggestions.

ui/public/locales/en.json

ui/src/views/iam/DeleteAccount.vue

ui/public/locales/en.json

ui/src/config/section/account.js

Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>

Imvedansh · 2025-04-30T20:56:49Z

@blueorangutan ui

blueorangutan · 2025-04-30T20:58:03Z

@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-04-30T21:15:22Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10760 (QA-JID-609)

DaanHoogland · 2025-05-01T06:34:09Z

@bernardodemarco can you check again?

bernardodemarco

lgtm, verified in the QA env

DaanHoogland · 2025-05-02T07:32:46Z

@Imvedansh , this is tested and reviewed, but still in draft. Do you consider it ready?

Imvedansh · 2025-05-02T14:10:26Z

@Imvedansh , this is tested and reviewed, but still in draft. Do you consider it ready?

@DaanHoogland Yes, it's ready. I was just working on making it more efficient and easier to understand for future contributors, will live it asap

DaanHoogland · 2025-05-02T15:36:12Z

@Imvedansh , this is tested and reviewed, but still in draft. Do you consider it ready?

@DaanHoogland Yes, it's ready. I was just working on making it more efficient and easier to understand for future contributors, will live it asap

ok, add a new PR if you want to improve more ;)

Imvedansh · 2025-05-02T16:18:39Z

@Imvedansh , this is tested and reviewed, but still in draft. Do you consider it ready?

@DaanHoogland Yes, it's ready. I was just working on making it more efficient and easier to understand for future contributors, will live it asap

ok, add a new PR if you want to improve more ;)

Perfectoooo :)!

Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>

Imvedansh and others added 10 commits March 25, 2025 22:14

vpc fill gateway and netmask

6aa691c

Suggestion for CIDR in placeholder instead of input

1d7fc2a

netmask placeholder fix

217789e

Abstraction of logic and few minor fixes

873aaa3

Minor fix in network.js

d4b11ef

Removed repetitive code in VPCTierTab

6cd108e

Update ui/public/locales/en.json

60acacf

Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>

extra check to delete account

a69a86a

extra checks for deleting account

60c84d1

Merge branch 'apache:4.19' into 4.19

a968eb1

boring-cyborg bot added the component:UI label Apr 21, 2025

bernardodemarco self-requested a review April 21, 2025 18:08

DaanHoogland added this to the 4.19.3 milestone Apr 23, 2025

DaanHoogland added this to ACS 4.20.1 Apr 23, 2025

DaanHoogland approved these changes Apr 23, 2025

View reviewed changes

Brute commit for warning feature disable account first

c6e8e47

Imvedansh added 3 commits April 24, 2025 00:02

Code Quality improved

52a9233

removing Wrapper.vue

33e11f3

New file DAW.vue added

a730e03

removed duplication in en.json

422bcc0

Imvedansh requested a review from DaanHoogland April 23, 2025 19:24

DaanHoogland approved these changes Apr 24, 2025

View reviewed changes

bernardodemarco reviewed Apr 25, 2025

View reviewed changes

ui/public/locales/en.json Outdated Show resolved Hide resolved

ui/src/views/iam/DeleteAccount.vue Outdated Show resolved Hide resolved

ui/public/locales/en.json Outdated Show resolved Hide resolved

ui/src/config/section/account.js Outdated Show resolved Hide resolved

Imvedansh and others added 3 commits April 26, 2025 08:56

Update ui/public/locales/en.json

99c17e9

Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>

Merge branch 'apache:4.19' into 4.19

eb5b254

Suggested fixes

1d3e374

DaanHoogland requested a review from bernardodemarco May 1, 2025 06:34

bernardodemarco approved these changes May 1, 2025

View reviewed changes

Imvedansh marked this pull request as ready for review May 2, 2025 14:10

DaanHoogland merged commit 1f8442e into apache:4.19 May 2, 2025
25 of 26 checks passed

github-project-automation bot moved this to Done in ACS 4.20.1 May 2, 2025

DaanHoogland mentioned this pull request May 16, 2025

Improve "Delete Account" pop-up verbiage #9480

Closed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025

Extra checks in UI when deleting accounts (apache#10760)

fba7c4a

Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>

DaanHoogland mentioned this pull request Jul 9, 2025

Unable to remove accounts from the UI/Accounts page using the main button #9904

Closed

scottsignal mentioned this pull request Aug 21, 2025

UI: Make Domain Deletion Consistent with Account Deletion #11497

Closed

Conversation

Imvedansh commented Apr 21, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

Imvedansh commented Apr 23, 2025

Uh oh!

blueorangutan commented Apr 23, 2025

Uh oh!

blueorangutan commented Apr 23, 2025

Uh oh!

codecov bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Imvedansh commented Apr 23, 2025

Uh oh!

blueorangutan commented Apr 23, 2025

Uh oh!

blueorangutan commented Apr 23, 2025

Uh oh!

Imvedansh commented Apr 23, 2025

Uh oh!

blueorangutan commented Apr 23, 2025

Uh oh!

blueorangutan commented Apr 23, 2025

Uh oh!

Imvedansh commented Apr 23, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Apr 24, 2025

Uh oh!

Imvedansh commented Apr 24, 2025

Uh oh!

bernardodemarco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Imvedansh commented Apr 30, 2025

Uh oh!

blueorangutan commented Apr 30, 2025

Uh oh!

blueorangutan commented Apr 30, 2025

Uh oh!

DaanHoogland commented May 1, 2025

Uh oh!

bernardodemarco left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented May 2, 2025

Uh oh!

Imvedansh commented May 2, 2025

Uh oh!

DaanHoogland commented May 2, 2025

Uh oh!

Uh oh!

Imvedansh commented May 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Apr 23, 2025 •

edited

Loading